hyung-hwan/moo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

attempted to improve performance of moo_truncfpdec() and moo_truncfpdecval() but the changes made don't seem to improve performance

Browse Source
This commit is contained in:
hyunghwan.chung 2019-02-19 13:59:19 +00:00
parent 26dae2508d
commit 4a6428445b
2 changed files with 78 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
moo/kernel/test-001.moo
View File

@ -257,5 +257,8 @@ extend MyObject
tb := tc at: idx. tb := tc at: idx.
System log(System.Log.INFO, idx asString, (if (tb value) { ' PASS' } else { ' FAIL' }), S'\n'). System log(System.Log.INFO, idx asString, (if (tb value) { ' PASS' } else { ' FAIL' }), S'\n').
]. ].
6000p99 dump.
} }
} }

76
moo/lib/number.c
View File

@ -26,6 +26,43 @@
#include "moo-prv.h" #include "moo-prv.h"
static moo_ooi_t pow_of_ten[] = {
1L,
10L,
100L,
1000L,
10000L,
100000L,
#if (MOO_SIZEOF_OOI_T >= 4)
1000000L,
10000000L,
100000000L,
1000000000L,
#endif
#if (MOO_SIZEOF_OOI_T >= 8)
10000000000L,
100000000000L,
1000000000000L,
10000000000000L,
100000000000000L,
1000000000000000L,
10000000000000000L,
100000000000000000L,
1000000000000000000L,
#endif
#if (MOO_SIZEOF_OOI_T >= 16)
10000000000000000000L,
100000000000000000000L,
1000000000000000000000L,
10000000000000000000000L,
100000000000000000000000L,
1000000000000000000000000L,
10000000000000000000000000L,
100000000000000000000000000L,
1000000000000000000000000000L,
#endif
};
moo_oop_t moo_makefpdec (moo_t* moo, moo_oop_t value, moo_ooi_t scale) moo_oop_t moo_makefpdec (moo_t* moo, moo_oop_t value, moo_ooi_t scale)
{ {
moo_oop_fpdec_t fpdec; moo_oop_fpdec_t fpdec;
@ -123,10 +160,12 @@ moo_oop_t moo_truncfpdecval (moo_t* moo, moo_oop_t iv, moo_ooi_t cs, moo_ooi_t n
{ {
/* this function truncates an existing fixed-point decimal value only if /* this function truncates an existing fixed-point decimal value only if
* the existing scale is greater than the new scale given. * the existing scale is greater than the new scale given.
* [NOTE] this doesn't work on the fpdec object. */ * [NOTE] this doesn't work on the fpdec object but on the inner integra
* fpdec value. */
if (cs > ns) if (cs > ns)
{ {
#if 0
do do
{ {
/* TODO: optimization... less divisions */ /* TODO: optimization... less divisions */
@ -135,6 +174,17 @@ moo_oop_t moo_truncfpdecval (moo_t* moo, moo_oop_t iv, moo_ooi_t cs, moo_ooi_t n
cs--; cs--;
} }
while (cs > ns); while (cs > ns);
#else
moo_oow_t dec, rem = cs - ns;
do
{
dec = (rem >= MOO_COUNTOF(pow_of_ten) - 1)? (MOO_COUNTOF(pow_of_ten) - 1): rem;
iv = moo_divints(moo, iv, MOO_SMOOI_TO_OOP(pow_of_ten[dec]), 0, MOO_NULL);
if (!iv) return MOO_NULL;
rem -= dec;
}
while (rem > 0);
#endif
} }
return iv; return iv;
@ -168,6 +218,7 @@ moo_oop_t moo_truncfpdec (moo_t* moo, moo_oop_t x, moo_ooi_t ns)
if (cs > ns) if (cs > ns)
{ {
/* same as moo_truncfpdecval() */ /* same as moo_truncfpdecval() */
#if 0
do do
{ {
/* TODO: optimization... less divisions */ /* TODO: optimization... less divisions */
@ -176,9 +227,21 @@ moo_oop_t moo_truncfpdec (moo_t* moo, moo_oop_t x, moo_ooi_t ns)
cs--; cs--;
} }
while (cs > ns); while (cs > ns);
#else
moo_oow_t dec, rem = cs - ns;
do
{
dec = (rem >= MOO_COUNTOF(pow_of_ten) - 1)? (MOO_COUNTOF(pow_of_ten) - 1): rem;
xv = moo_divints(moo, xv, MOO_SMOOI_TO_OOP(pow_of_ten[dec]), 0, MOO_NULL);
if (!xv) return MOO_NULL;
rem -= dec;
}
while (rem > 0);
#endif
} }
else /*if (cs < ns)*/ else /*if (cs < ns)*/
{ {
#if 0
do do
{ {
xv = moo_mulints(moo, xv, MOO_SMOOI_TO_OOP(10)); xv = moo_mulints(moo, xv, MOO_SMOOI_TO_OOP(10));
@ -186,6 +249,17 @@ moo_oop_t moo_truncfpdec (moo_t* moo, moo_oop_t x, moo_ooi_t ns)
cs++; cs++;
} }
while (cs < ns); while (cs < ns);
#else
moo_oow_t dec, rem = ns - cs;
do
{
dec = (rem >= MOO_COUNTOF(pow_of_ten) - 1)? (MOO_COUNTOF(pow_of_ten) - 1): rem;
xv = moo_mulints(moo, xv, MOO_SMOOI_TO_OOP(pow_of_ten[dec]));
if (!xv) return MOO_NULL;
rem -= dec;
}
while (rem > 0);
#endif
} }
/* moo_makefpdec returns xv if ns <= 0. so it's safe to call it /* moo_makefpdec returns xv if ns <= 0. so it's safe to call it