hyung-hwan/hcl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change to a single byte to encoded class attribute
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
hyung-hwan 2024-10-05 13:47:27 +09:00
parent 3f350dd38a
commit e6dd0f06a4
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/comp.c
View File

@ -2473,7 +2473,7 @@ static int check_class_attr_list (hcl_t* hcl, hcl_cnode_t* attr_list, unsigned i
} flag_tab[] = { } flag_tab[] = {
{ "v", HCL_CLASS_SPEC_FLAG_INDEXED }, { "v", HCL_CLASS_SPEC_FLAG_INDEXED },
{ "var", HCL_CLASS_SPEC_FLAG_INDEXED }, { "var", HCL_CLASS_SPEC_FLAG_INDEXED },
{ "variable", HCL_CLASS_SPEC_FLAG_INDEXED }, { "varying", HCL_CLASS_SPEC_FLAG_INDEXED },
{ "immutable", HCL_CLASS_SPEC_FLAG_IMMUTABLE }, { "immutable", HCL_CLASS_SPEC_FLAG_IMMUTABLE },
{ "uncopyable", HCL_CLASS_SPEC_FLAG_UNCOPYABLE }, { "uncopyable", HCL_CLASS_SPEC_FLAG_UNCOPYABLE },
}; };
@ -2545,11 +2545,17 @@ static int check_class_attr_list (hcl_t* hcl, hcl_cnode_t* attr_list, unsigned i
return -1; return -1;
} }
/*
* upper 4 bits: object flags - only 4 bit flags are possible
* lower 4 bits: object type for indexing/variablilty - 16 different combinations are possible
* these are kept as compact as possbile to make use a single byte in encoding this information
* for the bytecode instruction CLASS_ENTER
*/
for (i = 0; i < HCL_COUNTOF(flag_tab); i++) for (i = 0; i < HCL_COUNTOF(flag_tab); i++)
{ {
if (hcl_comp_oochars_bcstr(tokptr, toklen, flag_tab[i].name) == 0) if (hcl_comp_oochars_bcstr(tokptr, toklen, flag_tab[i].name) == 0)
{ {
if ((ct >> 8) & flag_tab[i].flag) if ((ct >> 4) & flag_tab[i].flag)
{ {
conflict: conflict:
hcl_setsynerrbfmt ( hcl_setsynerrbfmt (
@ -2557,7 +2563,7 @@ static int check_class_attr_list (hcl_t* hcl, hcl_cnode_t* attr_list, unsigned i
"conflicting or duplicate class attribute name '%.*js'", toklen, tokptr); "conflicting or duplicate class attribute name '%.*js'", toklen, tokptr);
return -1; return -1;
} }
ct |= (flag_tab[i].flag << 8); ct |= (flag_tab[i].flag << 4);
break; break;
} }
} }
@ -2567,7 +2573,7 @@ static int check_class_attr_list (hcl_t* hcl, hcl_cnode_t* attr_list, unsigned i
{ {
if (hcl_comp_oochars_bcstr(tokptr, toklen, type_tab[i].name) == 0) if (hcl_comp_oochars_bcstr(tokptr, toklen, type_tab[i].name) == 0)
{ {
if (ct & 0x7F) goto conflict; if (ct & 0x0F) goto conflict;
ct = type_tab[i].indexed_type; ct = type_tab[i].indexed_type;
break; break;
} }