hyung-hwan/hcl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

implemented sqrt for fixed-point decimal.

Browse Source 
fixed a bug in getting sqrt of a negative number
This commit is contained in:
hyung-hwan 2018-04-04 04:41:23 +00:00
parent d5097b998a
commit 46dc1968ad
2 changed files with 39 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/bigint.c
View File

@ -3956,6 +3956,13 @@ hcl_oop_t hcl_sqrtint (hcl_t* hcl, hcl_oop_t x)
{ {
/* TODO: find a faster and more efficient algorithm??? */ /* TODO: find a faster and more efficient algorithm??? */
hcl_oop_t a, b, m, m2, t; hcl_oop_t a, b, m, m2, t;
int neg;
if (!hcl_isint(hcl, x))
{
hcl_seterrbfmt (hcl, HCL_EINVAL, "parameter not integer - %O", x);
return HCL_NULL;
}
a = hcl->_nil; a = hcl->_nil;
b = hcl->_nil; b = hcl->_nil;
@ -3968,6 +3975,18 @@ hcl_oop_t hcl_sqrtint (hcl_t* hcl, hcl_oop_t x)
hcl_pushtmp (hcl, &m); hcl_pushtmp (hcl, &m);
hcl_pushtmp (hcl, &m2); hcl_pushtmp (hcl, &m2);
a = hcl_ltints(hcl, x, HCL_SMOOI_TO_OOP(0));
if (!a) goto oops;
if (a == hcl->_true)
{
/* the given number is a negative number.
* i will arrange the return value to be negative. */
x = hcl_negateint(hcl, x);
if (!x) goto oops;
neg = 1;
}
else neg = 0;
a = HCL_SMOOI_TO_OOP(1); a = HCL_SMOOI_TO_OOP(1);
b = hcl_bitshiftint(hcl, x, HCL_SMOOI_TO_OOP(-5)); b = hcl_bitshiftint(hcl, x, HCL_SMOOI_TO_OOP(-5));
if (!b) goto oops; if (!b) goto oops;
@ -4001,7 +4020,11 @@ hcl_oop_t hcl_sqrtint (hcl_t* hcl, hcl_oop_t x)
} }
hcl_poptmps (hcl, 5); hcl_poptmps (hcl, 5);
return hcl_subints(hcl, a, HCL_SMOOI_TO_OOP(1)); x = hcl_subints(hcl, a, HCL_SMOOI_TO_OOP(1));
if (!x) return HCL_NULL;
if (neg) x = hcl_negateint(hcl, x);
return x;
oops: oops:
hcl_poptmps (hcl, 5); hcl_poptmps (hcl, 5);

15
lib/number.c
View File

@ -352,16 +352,25 @@ hcl_oop_t hcl_sqrtnum (hcl_t* hcl, hcl_oop_t x)
} }
else else
{ {
/* TODO: debug this part... this part is buggy. not complete yet */
hcl_oop_t v; hcl_oop_t v;
hcl_ooi_t scale; hcl_ooi_t i, scale;
scale = HCL_OOP_TO_SMOOI(((hcl_oop_fpdec_t)x)->scale); scale = HCL_OOP_TO_SMOOI(((hcl_oop_fpdec_t)x)->scale);
v = ((hcl_oop_fpdec_t)x)->value; v = ((hcl_oop_fpdec_t)x)->value;
for (i = 0; i < scale ; i++)
{
v = hcl_mulints(hcl, v, HCL_SMOOI_TO_OOP(10));
if (!v)
{
hcl_poptmp (hcl);
return HCL_NULL;
}
}
v = hcl_sqrtint(hcl, v); v = hcl_sqrtint(hcl, v);
if (!v) return HCL_NULL; if (!v) return HCL_NULL;
return hcl_makefpdec(hcl, v, scale / 2); return hcl_makefpdec(hcl, v, scale);
} }
} }