hyung-hwan/hawk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixed a file descriptor leak
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
hyung-hwan 2024-04-21 15:24:14 +09:00
parent a7d3432c11
commit bea9b75fad
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/gem-nwif.c
View File

@ -141,7 +141,11 @@ int hawk_gem_bcstrtoifindex (hawk_gem_t* gem, const hawk_bch_t* ptr, unsigned in
HAWK_MEMSET (&ifr, 0, HAWK_SIZEOF(ifr)); HAWK_MEMSET (&ifr, 0, HAWK_SIZEOF(ifr));
len = hawk_copy_bcstr(ifr.ifr_name, HAWK_COUNTOF(ifr.ifr_name), ptr); len = hawk_copy_bcstr(ifr.ifr_name, HAWK_COUNTOF(ifr.ifr_name), ptr);
if (ptr[len] != '\0') return -1; /* name too long */ if (ptr[len] != '\0')
{
HAWK_CLOSE (h);
return -1; /* name too long */
}
x = ioctl(h, SIOCGIFINDEX, &ifr); x = ioctl(h, SIOCGIFINDEX, &ifr);
HAWK_CLOSE (h); HAWK_CLOSE (h);
@ -227,7 +231,11 @@ int hawk_gem_bcharstoifindex (hawk_gem_t* gem, const hawk_bch_t* ptr, hawk_oow_t
} }
HAWK_MEMSET (&ifr, 0, HAWK_SIZEOF(ifr)); HAWK_MEMSET (&ifr, 0, HAWK_SIZEOF(ifr));
if (hawk_copy_bchars_to_bcstr(ifr.ifr_name, HAWK_COUNTOF(ifr.ifr_name), ptr, len) < len) return -1; /* name too long */ if (hawk_copy_bchars_to_bcstr(ifr.ifr_name, HAWK_COUNTOF(ifr.ifr_name), ptr, len) < len)
{
HAWK_CLOSE (h);
return -1; /* name too long */
}
x = ioctl(h, SIOCGIFINDEX, &ifr); x = ioctl(h, SIOCGIFINDEX, &ifr);
HAWK_CLOSE (h); HAWK_CLOSE (h);