hyung-hwan/codepot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

changed parameter spec in svn_diff to avoid segfault

Browse Source
This commit is contained in:
hyung-hwan 2019-02-03 14:52:23 +00:00
parent 1cac3839e6
commit a8abcb5519
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codepot/pecl-svn/svn.c
View File

@ -1495,7 +1495,8 @@ PHP_FUNCTION(svn_diff)
svn_opt_revision_t revision1, revision2; svn_opt_revision_t revision1, revision2;
zend_bool ignore_content_type = 0; zend_bool ignore_content_type = 0;
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sl!sl!", /* sl!sl! caused segfault with PHP 7.3.2RC1. using slsl. */
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "slsl" /*"sl!sl!"*/,
&path1, &path1len, &rev1, &path1, &path1len, &rev1,
&path2, &path2len, &rev2)) { &path2, &path2len, &rev2)) {
return; return;
@ -1508,6 +1509,7 @@ PHP_FUNCTION(svn_diff)
} }
RETVAL_FALSE; RETVAL_FALSE;
printf (">>> %ld %ld\n", rev1, rev2);
if (rev1 <= 0) { if (rev1 <= 0) {
revision1.kind = svn_opt_revision_head; revision1.kind = svn_opt_revision_head;
} else { } else {